Skip to content

Fix: Disable Ben.Demystifier for UWP by default. #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2021
Merged

Fix: Disable Ben.Demystifier for UWP by default. #821

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bfcf97
Disabled Ben.Demystifier for UWP by default.
lucas-zimerman Feb 13, 2021
9775cb1
test
lucas-zimerman Feb 13, 2021
61b1ff4
Fix changelog number.
lucas-zimerman Feb 13, 2021
7fcf36e
wip
lucas-zimerman Feb 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Changes

- Fix UWP not registering exceptions (#821) @lucas-zimerman
- Fix tracing middleware (#813) @Tyrrrz

## 3.0.5
Expand Down
1 change: 0 additions & 1 deletion modules/Ben.Demystifier
Open in desktop
Submodule Ben.Demystifier deleted from a6fe04
5 changes: 3 additions & 2 deletions src/Sentry/SentryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,9 @@ public double TracesSampleRate
/// </summary>
public SentryOptions()
{
// from 3.0.0 uses Enhanced (Ben.Demystifier) by default which is a breaking change.
StackTraceMode = StackTraceMode.Enhanced;
// from 3.0.0 uses Enhanced (Ben.Demystifier) by default which is a breaking change
// unless you are using .NET Native which isn't compatible with Ben.Demystifier.
StackTraceMode = Runtime.Current.Name == ".NET Native" ? StackTraceMode.Original : StackTraceMode.Enhanced;

EventProcessorsProviders = new Func<IEnumerable<ISentryEventProcessor>>[] {
() => EventProcessors ?? Enumerable.Empty<ISentryEventProcessor>()
Expand Down