Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Oct 9, 2025

SentrySdk.CaptureFeedback now returns a SentryId that will be:

  • either the id of the newly captured feedback (if the call succeeds)
  • or SentryId.Empty and an error code (if the call fails)

An additional overload is also available with an extra out CaptureFeedbackResult that can be used to determine whether the call succeeded or what the specific reason for failure was otherwise.

Resolves #4319

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (version6@7645341). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Sentry/Extensibility/DisabledHub.cs 0.00% 4 Missing ⚠️
src/Sentry/Internal/Hub.cs 60.00% 4 Missing ⚠️
src/Sentry/Extensibility/HubAdapter.cs 50.00% 1 Missing ⚠️
src/Sentry/SentrySdk.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             version6    #4613   +/-   ##
===========================================
  Coverage            ?   73.11%           
===========================================
  Files               ?      479           
  Lines               ?    17336           
  Branches            ?     3419           
===========================================
  Hits                ?    12676           
  Misses              ?     3812           
  Partials            ?      848           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell jamescrosswell marked this pull request as ready for review October 9, 2025 05:50
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@bitsandfoxes
Copy link
Contributor

This looks great from the SDK for Unity POV.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't dispose of backpressure monitor when disposing the Hub Add return value to CaptureFeedback

5 participants