Skip to content

Remove Headers and Modules from SentryCocoaFramework before packing #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Remove Headers and Modules from SentryCocoaFramework before packing #4533

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
de6e8f3
Remove Headers and Modules from SentryCocoaFramework before packing
jamescrosswell Sep 17, 2025
ac3168a
Update CHANGELOG.md
jamescrosswell Sep 17, 2025
cf1254f
release: 5.15.1-maxpath.1
getsentry-bot Sep 18, 2025
b1fc427
Merge branch 'release/5.15.1-maxpath.1' into xcframework-no-headers
Sep 18, 2025
7a71a8d
Merge branch 'main' into xcframework-no-headers
jamescrosswell Sep 19, 2025
4317ae9
Update CHANGELOG.md
jamescrosswell Sep 19, 2025
d9d057a
Merge branch 'main' into xcframework-no-headers
jamescrosswell Sep 21, 2025
bfdd42d
Update CHANGELOG.md
jamescrosswell Sep 21, 2025
4e0a857
Merge branch 'main' into xcframework-no-headers
jamescrosswell Sep 22, 2025
065a155
Merge branch 'main' into xcframework-no-headers
jamescrosswell Oct 5, 2025
56f33bd
_GenerateSentryCocoaBindings and SanitizeSentryCocoaFramework run onl…
jamescrosswell Oct 5, 2025
7778c55
Update Sentry.Bindings.Cocoa.csproj
jamescrosswell Oct 6, 2025
45fcd3e
Update CHANGELOG.md
jamescrosswell Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Fail when building Blazor WASM with Profiling. We don't support profiling in Blazor WebAssembly projects. ([#4512](https://github.com/getsentry/sentry-dotnet/pull/4512))
- Do not overwrite user IP if it is set manually in ASP.NET sdk ([#4513](https://github.com/getsentry/sentry-dotnet/pull/4513))
- Fix `SentryOptions.Native.SuppressSignalAborts` and `SuppressExcBadAccess` on iOS ([#4521](https://github.com/getsentry/sentry-dotnet/pull/4521))
- Partial workaround for MAX_PATH issues when building iOS applications from Windows ([#4533](https://github.com/getsentry/sentry-dotnet/pull/4533))

### Dependencies

Expand Down
9 changes: 9 additions & 0 deletions src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,15 @@
<Exec Condition="'$(GITHUB_ACTIONS)' == 'true'" Command="pwsh ../../scripts/dirty-check.ps1 -PathToCheck $(MSBuildThisFileDirectory)" />
</Target>

<!-- Sanitize the xcframework before NativeReference resolution and packing -->
<Target Name="SanitizeSentryCocoaFramework"
AfterTargets="_GenerateSentryCocoaBindings"
BeforeTargets="ResolveNativeReferences"
Condition="$([MSBuild]::IsOSPlatform('OSX')) and Exists('$(SentryCocoaFramework)')">
<Message Importance="High" Text="Sanitizing $(SentryCocoaFramework): removing dSYMs, Headers, Modules, PrivateHeaders (including symlinks)." />
<Exec Command="bash -c 'find &quot;$(SentryCocoaFramework)&quot; -depth \( -name dSYMs -o -name Headers -o -name Modules -o -name PrivateHeaders \) -exec echo Removing {} \; -exec rm -rf {} + 2&gt;/dev/null || true'" />
</Target>

<!-- Workaround for https://github.com/xamarin/xamarin-macios/issues/15299 -->
<Target Name="_SetGeneratedSupportDelegatesInternal" BeforeTargets="CoreCompile" Condition="$([MSBuild]::IsOSPlatform('OSX'))"
Inputs="$(GeneratedSourcesDir)SupportDelegates.g.cs" Outputs="$(GeneratedSourcesDir)SupportDelegates.g.cs.stamp">
Expand Down
Loading