-
-
Couldn't load subscription status.
- Fork 225
chore(deps): update Java SDK to v8.21.1 #4508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
671d23e to
06e2af0
Compare
|
I was too quick to bump the Kotlin version in #4502. Probably better to revert from 2.2.0 (June 23, 2025) back to 2.0.0 (May 21, 2024) right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah, I had assumed we had to bump this in order to use the latest Sentry SDK for Java... ideally we'd target the oldest possible version we can get away with (so as not to force our customers to have to bump their versions in order to use Sentry). |
|
Yeah, for sentry-java 8.21.0 we had to bump the Kotlin version, but they hot-fixed it in 8.21.1: Is it too late to include this in sentry-dotnet 5.15.0? |
I don't think that release has gone out yet... maybe coordinate with @Flash0ver (I'm just about to go to sleep) if you want to cancel it and roll it out again. Otherwise, we could always make a 5.15.1 release. |
|
I prefer to retract the currently open -<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="2.0.0" />
+<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="2.2.0" />yet, rather than decrementing the dependency later in a patch-release again. |
I've retracted the 5.15.0 release... still not sure I follow what's going on with the versions above though. It looks like the Java SDK only depends on version 1.9.24, so why do we need to bump from version 2.0.0 to 2.2.0? |
|
There's no version 1.9.24 of the Xamarin.Kotlin.StdLib NuGet package. We use the nearest available version 2.0.0. The dependency was originally added in: When bumping sentry-java to 8.21.0 we had to bump Kotlin to 2.2.0 due to: The dependency on Kotlin 2.2 was reverted in sentry-java 8.21.1: => We reverted to 2.0.0. |
Ah, I see. Great - thank you! |
Bumps scripts/update-java.ps1 from 8.21.0 to 8.21.1.
Auto-generated by a dependency updater.
Changelog
8.21.1
Fixes