Skip to content

fix: InvalidOperationException sending attachments on Android with LLVM enabled #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

fix: InvalidOperationException sending attachments on Android with LLVM enabled #4276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb2f94b
fix: InvalidOperationException when sending attachments on Android wi…
jamescrosswell Jun 12, 2025
12a0664
Update CHANGELOG.md
jamescrosswell Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Fixes

- The HTTP instrumentation uses the span created for the outgoing request in the sentry-trace header, fixing the parent-child relationship between client and server ([#4264](https://github.com/getsentry/sentry-dotnet/pull/4264))
- InvalidOperationException sending attachments on Android with LLVM enabled ([#4276](https://github.com/getsentry/sentry-dotnet/pull/4276))

### Dependencies

Expand Down
3 changes: 2 additions & 1 deletion src/Sentry/Internal/PartialStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ public override async Task<int> ReadAsync(byte[] buffer, int offset, int count,
_innerStream.Position = innerPosition;
}

var read = await _innerStream.ReadAsync(buffer, offset, actualCount, cancellationToken)
// See https://github.com/getsentry/sentry-dotnet/issues/3101
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off, some .NET bug? how can we avoid this from happening again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have treat-warning-as-error on?

Copy link
Member

@Flash0ver Flash0ver Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we only have the Default ruleset enabled, depending on the .NET SDK version.
We could enable All rules, and also lock/pin to a specific .NET SDK ruleset for deterministic builds.

Opened new issue as follow-up for more code analysis rules and diagnostics: #4287

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have treat-warning-as-error on?

We do but the analyzers for this error only appear to trigger in the .NET 10 SDK (we weren't getting any errors before that).

var read = await _innerStream.ReadAsync(buffer.AsMemory(offset, actualCount), cancellationToken)
.ConfigureAwait(false);

if (_length != null)
Expand Down
Loading