fix: ExtraData not captured for Breadcrumbs in MauiEventsBinder #4254
+205
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
commented
Jun 5, 2025
test/Sentry.Maui.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
Outdated
Show resolved
Hide resolved
jamescrosswell
commented
Jun 5, 2025
Flash0ver
reviewed
Jun 5, 2025
Flash0ver
reviewed
Jun 5, 2025
jamescrosswell
commented
Jun 10, 2025
Flash0ver
reviewed
Jun 16, 2025
Flash0ver
reviewed
Jun 17, 2025
| public BreadcrumbEvent( | ||
| object? sender, | ||
| string eventName, | ||
| params IEnumerable<(string key, string value)> extraData) : this(sender, eventName, extraData.Select( |
There was a problem hiding this comment.
final comment: deferred execution
The Select assigned to ExtraData will have deferred execution.
Is this expected / intended?
On the other hand, since we accept IEnumerable in the .ctors, the user could pass IEnumerables with deferred execution anyway.
On second thought ... I believe this is great as it is.
Also considering we're enumerating through it only a single time, so materializing the IEnumerable beforehand would actually be slightly slower and allocate more memory.
Flash0ver
approved these changes
Jun 17, 2025
This was referenced Jul 28, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4252: