- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 225
Rename MemoryInfo.AllocatedBytes to MemoryInfo.TotalAllocatedBytes #4243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MemoryInfo.AllocatedBytes to MemoryInfo.TotalAllocatedBytes #4243
Conversation
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #4243      +/-   ##
==========================================
- Coverage   75.73%   73.05%   -2.68%     
==========================================
  Files         357      456      +99     
  Lines       13466    16559    +3093     
  Branches     2671     3302     +631     
==========================================
+ Hits        10198    12097    +1899     
- Misses       2593     3612    +1019     
- Partials      675      850     +175     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps for raising and addressing this @KnapSac !
<!-- Describe your PR here. --> Adds the `total_allocated_bytes` property added in getsentry/sentry-dotnet#4243 to the static types. cc @jamescrosswell <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes #4242.