-
-
Notifications
You must be signed in to change notification settings - Fork 226
work around iOS SHA1 bug #4143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work around iOS SHA1 bug #4143
Conversation
|
Overall, this looks good. We do have another reference to sentry-dotnet/src/Sentry/Internal/InstallationIdHelper.cs Lines 130 to 131 in 7da3cf3
It's a secondary fallback that's used here: sentry-dotnet/src/Sentry/Internal/InstallationIdHelper.cs Lines 30 to 33 in 7da3cf3
So that code only executes if we fail to obtain either a persistent or a hardware id. I don't think that should block this PR... but if we continue to have issues, I can't see an easy way around that one short of rolling out our own hashing function. |
I edited this on GitHub 😅
Hopefully starts a discussion
Resolves #4131: