-
-
Notifications
You must be signed in to change notification settings - Fork 226
fix: rename DisableSentryNative to SentryNative
#4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename DisableSentryNative to SentryNative
#4134
Conversation
| #if NET9_0_OR_GREATER | ||
| // FeatureSwitchDefinition should help with trimming disabled code. | ||
| // This way, `SentryNative.IsEnabled` should be treated as a compile-time constant for trimmed apps. | ||
| // This way, `Sentry.Native.IsEnabled` should be treated as a compile-time constant for trimmed apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // This way, `Sentry.Native.IsEnabled` should be treated as a compile-time constant for trimmed apps. | |
| // This way, `SentryNative.IsEnabled` should be treated as a compile-time constant for trimmed apps. |
It's internal static class SentryNative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ... it's referring to the property name, not the switch name ... my bad ... reverted
This reverts commit b914cbc.
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
follow-up to #4107
DisableSentryNativetoSentryNativeSentry..truetofalse|disableSentryImplicitUsings, also an opt-outImplicitUsings, which is an opt-in