Skip to content

fix: MSVCRT build warning on Windows #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 14, 2025
Merged

fix: MSVCRT build warning on Windows #4111

merged 5 commits into from
Apr 14, 2025
+6 −0

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Apr 14, 2025 •
edited
Loading

Fixes LNK4098 linker warning when compiling applications using AOT on windows.

Resolves #3928 :

getsentry-bot and others added 3 commits April 14, 2025 17:57
@getsentry-bot
fix: MSVCRT build warning on Windows
8bcd974 
Fixes `LNK4098` linker warning when compiling application AOT on windows.

Resolves #3928 :
- #3928
@getsentry-bot
Update CHANGELOG.md
0445fd7
@jamescrosswell
Update Sentry.targets
2742756
@jamescrosswell jamescrosswell marked this pull request as ready for review April 14, 2025 13:09
@jamescrosswell jamescrosswell marked this pull request as draft April 14, 2025 13:10
@jamescrosswell jamescrosswell marked this pull request as ready for review April 14, 2025 21:38
@jamescrosswell jamescrosswell merged commit 4e7a114 into main Apr 14, 2025
27 checks passed
@jamescrosswell jamescrosswell deleted the fix/msvcrt-build-warning branch April 14, 2025 21:39
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Closed
This was referenced Aug 18, 2025
Closed
Closed
This was referenced Sep 8, 2025
Closed
Closed
Closed
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
This was referenced Oct 6, 2025
Open
Closed
Closed
@ysmoradi ysmoradi mentioned this pull request Oct 14, 2025
Open
This was referenced Oct 20, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flash0ver Flash0ver Awaiting requested review from Flash0ver Flash0ver is a code owner

1 more reviewer

@aritchie aritchie aritchie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MSVCRT build warning when building Windows App SDK (WinUI) release binaries with native AOT

4 participants

@jamescrosswell @aritchie @getsentry-bot