Fix: Add distinct set-commits release options #4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `SentrySetCommitReleaseOptions` to Sentry.targets that can be configured independently of `SentryReleaseOptions`, since it's possible for these to be conflicting. Fixes #4108
Flash0ver
reviewed
Apr 24, 2025
| <Message Importance="High" Text="Setting Sentry commits" /> | ||
| <Exec | ||
| Command="$(SentryCLIBaseCommand) releases set-commits $(SentrySetCommitOptions) $(_SentryRelease) $(SentryReleaseOptions)" | ||
| Command="$(SentryCLIBaseCommand) releases set-commits $(SentrySetCommitOptions) $(_SentryRelease) $(SentrySetCommitReleaseOptions)" |
There was a problem hiding this comment.
question: Should we prefix this new property with _?
This property is not intended to be set by consuming projects, right?
And we also don't intend to mention this property in the documentation, do we?
Should we then prefix it with _ to communicate "internal use only)?
There was a problem hiding this comment.
No it's supposed to be exposed to SDK users, same as the SentryReleaseOptions. It basically let's users specify whatever options they want (anything documented by sentry-cli releases set-commits --help).
For example they could put --ignore-missing in here.
bruno-garcia
approved these changes
Apr 28, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SentrySetCommitReleaseOptionsto Sentry.targets that can be configured independently ofSentryReleaseOptions, since it's possible for these to be conflicting.Fixes #4108
Testing
This was tested manually with the parameters described in the issue that this PR resolves.