Skip to content

Fix fromjson serialization of breadcrumbs from android #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix fromjson serialization of breadcrumbs from android #3993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6140bb
Fix fromjson serialization of breadcrumbs from android
aritchie Feb 21, 2025
9594fd0
Update CHANGELOG.md
aritchie Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Fix mismapped breadcrumb levels coming in from native to dotnet SDK ([#3993](https://github.com/getsentry/sentry-dotnet/pull/3993))

### Features

- Serilog scope properties are now sent with Sentry events ([#3976](https://github.com/getsentry/sentry-dotnet/pull/3976))
Expand Down
12 changes: 11 additions & 1 deletion src/Sentry/Breadcrumb.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,18 @@ public static Breadcrumb FromJson(JsonElement json)
var type = json.GetPropertyOrNull("type")?.GetString();
var data = json.GetPropertyOrNull("data")?.GetStringDictionaryOrNull();
var category = json.GetPropertyOrNull("category")?.GetString();
var level = json.GetPropertyOrNull("level")?.GetString()?.ParseEnum<BreadcrumbLevel>() ?? default;

var levelString = json.GetPropertyOrNull("level")?.GetString();
var level = levelString?.ToUpper() switch
{
"DEBUG" => BreadcrumbLevel.Debug,
"INFO" => BreadcrumbLevel.Info,
"WARNING" => BreadcrumbLevel.Warning,
"ERROR" => BreadcrumbLevel.Error,
"CRITICAL" => BreadcrumbLevel.Critical,
"FATAL" => BreadcrumbLevel.Critical,
_ => default
};
return new Breadcrumb(timestamp, message, type, data!, category, level);
}
}
Loading