Skip to content

Skip flaky test (EventPipeSession_ReceivesExpectedCLREvents) #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Skip flaky test (EventPipeSession_ReceivesExpectedCLREvents) #3949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,9 @@ public async Task Profiler_AfterTimeout_Stops()
[SkippableFact]
public async Task EventPipeSession_ReceivesExpectedCLREvents()
{
SampleProfilerSession? session = null;
SkipIfFailsInCI(() => session = SampleProfilerSession.StartNew(_testOutputLogger));
Skip.If(TestEnvironment.IsGitHubActions, "Flaky on CI");

var session = SampleProfilerSession.StartNew(_testOutputLogger);
using (session)
{
var eventsReceived = new HashSet<string>();
Expand All @@ -194,7 +195,6 @@ public async Task EventPipeSession_ReceivesExpectedCLREvents()
var loadedMethods = new HashSet<string>();
session!.EventSource.Clr.MethodLoadVerbose += (MethodLoadUnloadVerboseTraceData ev) => loadedMethods.Add(ev.MethodName);


await session.WaitForFirstEventAsync(CancellationToken.None);
var limitMs = 50;
var sut = new SamplingTransactionProfiler(_testSentryOptions, session, limitMs, CancellationToken.None);
Expand Down
Loading