-
-
Notifications
You must be signed in to change notification settings - Fork 225
Add SentryOptions.DisableSentryHttpMessageHandler #3879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we flip this to false automagically if OpenTelemetry.Instrumentation.Http is installed? If so, do we need a public options or would internal with InternalsVisibleTo be enough?
Co-authored-by: Bruno Garcia <[email protected]>
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add SentryOptions.DisableSentryHttpMessageHandler ([#3879](https://github.com/getsentry/sentry-dotnet/pull/3879))If none of the above apply, you can opt out of this check by adding |
Addresses the duplicate trace problem described in #3843:
Essentially we allow SDK users to disable the
SentryHttpMessageHandlerif they are already using theOpenTelemetry.Instrumentation.Httppackage to trace outbound requests... to avoid duplicate instrumentation.This PR does not address any issues around YARP - that would require separate exploration.