Fix: ArgumentNullException in FormRequestPayloadExtractor when handling invalid form data on ASP.NET #3734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3701
Analysis
This is handled differently in ASP.NET vs ASP.NET Core.
In ASP.NET Core, the implementation for IHttpRequest is:
sentry-dotnet/src/Sentry.AspNetCore/HttpRequestAdapter.cs
Lines 16 to 18 in 2639611
In ASP.NET the implementation is:
sentry-dotnet/src/Sentry.AspNet/Internal/SystemWebHttpRequest.cs
Lines 15 to 16 in e75d537
Seemingly it's only a problem in ASP.NET... pushing an initial PR so I can switch to my windows box for development.