-
-
Notifications
You must be signed in to change notification settings - Fork 225
fix: Android - make sure logcat.log is attached to unhandled event (SIGSEGV Segfault) #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+199
−6
Merged
Changes from 20 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
2efc4bb
Sentry SDK - Android Bindings | upgrade the JavaSDK to 7.15.0-alpha.1
bricefriha 1c12ffa
#1027 - Sentry Android | implement NDKhandlerStrategy
bricefriha 7cc7951
Android Bindings - NDKHandler | fix enum conversion
bricefriha 455c1d8
NdkHandlerStrategy | fix a oopsi : some code I removed by mistake
bricefriha 2160ab6
unit test - MAUI | handler strategy
bricefriha 6d0dc19
Change logs - handler strategy
bricefriha bfdf2f1
Update CHANGELOG.md
bricefriha f59d990
Unit tests - Maui | indentation
bricefriha a9c9f88
Update src/Sentry/Platforms/Android/SentrySdk.cs
bricefriha 46f2d26
Android - Handler Strategy | add ToJava() extension
bricefriha 8699f7a
Android - Handler Strategy | simplify the `HandlerStrategy` property …
bricefriha bc74c42
Android bindings - `7.15.0-alpha.1` config | clean up the auto indent…
bricefriha c4d75ce
Android - Handler Strategy | Values() can't ever be null
bricefriha d711700
Sentry.Bindings.Android - config | restore file
bricefriha 72eb9ff
Android - Handler Strategy Android/SentrySdk.cs | Restore `SentryAndr…
bricefriha e9ca2d8
Android - Handler Strategy Android/SentrySdk.cs | remove useless cast
bricefriha 80221e9
Android - Handler Strategy | move NdkHandlerStrategy.cs to the Androi…
bricefriha d29c2b8
Android - Handler Strategy | document HandlerStrategy better
bricefriha 57aeb47
Android - binding config | restore to edd0be4
bricefriha 03da282
Android - Handler Strategy | HandlerStrategy improve documentation
bricefriha f803f9b
cleanup - Android Bindings - NdkHandlerStrategy.cs | opt for a File-s…
bricefriha 0141fe6
Android - NDK handler | set default handler to SENTRY_HANDLER_STRATEG…
bricefriha 62816a6
Unit tests - MAUI Android - NDK handler | remove them - as the user d…
bricefriha 4b24ba6
Merge branch 'main' into fix/#3461
jamescrosswell e977797
Bindings Android - | change version to 7.15.0-alpha.1 to make CI happy
bricefriha a2f8368
Device Tests - MAUI android logcats | create tests for the most commo…
bricefriha 164e096
Device tests - logcats attchment + fix CI | remove global android ref…
bricefriha 185172a
Device tests - logcat | fix CI: encapsulate Android `options.Android.…
bricefriha 8c6eaae
Device Test - MAUI Logcats | Remove Android block
bricefriha 28f16f0
Device Test - MAUI Logcats | Test unhandled exceptions
bricefriha 03c23c4
Device Test - MAUI Logcats | Test handled exceptions
bricefriha 7870b79
Device Test - MAUI Logcats | restore android blocks to prevent the CI…
bricefriha 7023620
Unit tests - Android LogCatIntegration options | test HandlerStrategy…
bricefriha cc574d5
Merge branch 'main' into fix/#3461
bricefriha abfa306
Unit tests - Android LogCatIntegration | fix `#if Android` block
bricefriha 068983e
Update CHANGELOG.md
bricefriha 3b97c61
Update CHANGELOG.md entry
bricefriha ed094f9
Merge branch 'main' into fix/#3461
bricefriha cff630b
Format code
getsentry-bot 151f967
Device tests - SentryMauiLogcatsTests | fix syntax issue after merge
bricefriha 42e4ab3
merge SentryMauiLogcatsTests
bricefriha eac7596
CHANGELOG.md | switch the #3694 entry back to unreleased
bricefriha d9516bf
Merge branch 'main' into fix/#3461
jamescrosswell 7c36b47
Merge branch 'main' into pr/3694
jamescrosswell 5682e34
Update CHANGELOG.md
jamescrosswell 010101a
Merge branch 'main' into fix/#3461
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| namespace Sentry | ||
| { | ||
bricefriha marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /// <summary> | ||
| /// Handler strategy | ||
| /// </summary> | ||
| /// | ||
| public enum NdkHandlerStrategy | ||
| { | ||
| /// <summary> | ||
| /// default handler strategy -> value 0 | ||
| /// </summary> | ||
| SENTRY_HANDLER_STRATEGY_DEFAULT, | ||
| /// <summary> | ||
| /// Handle strategy chain at start -> value 1 | ||
| /// </summary> | ||
| SENTRY_HANDLER_STRATEGY_CHAIN_AT_START, | ||
|
|
||
|
|
||
| } | ||
| /// <summary> | ||
| /// Extension class of strategy containing relevant its actions | ||
| /// </summary> | ||
| public static class HandlerStrategyExtension | ||
| { | ||
| internal static JavaSdk.Android.Core.NdkHandlerStrategy ToJava(this NdkHandlerStrategy strategy) | ||
| { | ||
| return JavaSdk.Android.Core.NdkHandlerStrategy.Values()![(int)strategy]; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.