Skip to content

Conversation

@bruno-garcia
Copy link
Member

Over 3k installs. No issues (afaik?)

Seems like we can GA this.

It doesn't do much other than set the right properties so things don't blow up on init, so seems pretty safe

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part all looks fine.

From what I can tell, we still haven't merged any PRs releated to embedding the JS SDK... which would presumably be the most complex thing to implement and maintain.

@bruno-garcia
Copy link
Member Author

This part all looks fine.

From what I can tell, we still haven't merged any PRs releated to embedding the JS SDK... which would presumably be the most complex thing to implement and maintain.

yeah but if we haver another alpha bit, we can append the alpha again before a release.
Just gotta be aware that if we add -beta on the whole release, we'll be appending something twice (I think there's a way around it actually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants