-
-
Notifications
You must be signed in to change notification settings - Fork 225
feat: BeforeCaptureScreenshot option #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 32 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
e3cd860
feature - #3353 | Add `BeforeCaptureScreenshot` callback
bricefriha a134cbe
MAUI sample - options | Add `BeforeCaptureScreenshot` option to the M…
bricefriha 91fa764
unit test - MAUI | Add test for when adding BeforeCaptureScreenshot o…
bricefriha c453695
feature - change log | for `BeforeCaptureScreenshot`
bricefriha 6372d79
sample - MAUI | uncomment options.BeforeCaptureScreenshot
bricefriha 99bfb1a
Samples - MAUI | enable `deploy`
bricefriha c45d817
feature - change log | update the chande log entry to make it more de…
bricefriha e203911
#3661 - update | changes requested to BeforeCaptureScreenshotInternal
bricefriha 7f0b410
MAUI tests - options | update test accordingly to the changes request…
bricefriha 4ccd5ec
cleanup - | removing commented code
bricefriha fddd5af
changelog - BeforeCaptureScreenshot | fix typos
bricefriha 6e95957
unit test - MAUI | remove BeforeCaptureScreenshot default
bricefriha 4104623
config - Samples - MAUI | roll back changes to enable `deploy`
bricefriha 576d154
Merge branch 'feat/programmatic_sc_attachement' of https://github.com…
bricefriha 6ac5ac0
cleanup - convention | adding brackets to the if statement of the Bef…
bricefriha 273c913
Merge branch 'feat/programmatic_sc_attachement' of https://github.com…
bricefriha 80cd35d
options - MAUI | fix ambiguity _beforeSend -> _beforeCaptureScreenshot
bricefriha 2152253
cleaning - SentryMauiOptions | keep file patern
bricefriha 809567b
Format code
getsentry-bot 9703a34
Unit test - MAUI options beforescreenshot | change True() to IsNotNull()
bricefriha 601e7f6
Update test/Sentry.Maui.Tests/SentryMauiOptionsTests.cs
bruno-garcia f94fe51
option - Maui BeforeCaptureScreenshot | change null check pattern
bricefriha 1e7b92a
option - Maui BeforeCaptureScreenshot | Change the signiture to do so…
bricefriha cba76b6
option - Maui BeforeCaptureScreenshot | remove the hint parameter as …
bricefriha 2785afc
option - Maui BeforeCaptureScreenshot | update MAUI sample
bricefriha 8439525
option - Maui BeforeCaptureScreenshot | update unit tests
bricefriha 498e953
option - Maui BeforeCaptureScreenshot | Remove the useless return of …
bricefriha d53c918
option - Maui BeforeCaptureScreenshot | update sample
bricefriha c6ddfb7
option - Maui BeforeCaptureScreenshot | correct SetBeforeCapture()
bricefriha d0a4b35
option - Maui BeforeCapture | rename and documentation
bricefriha 22eba9b
test- Maui BeforeCapture | update tests and sample
bricefriha da28176
Merge branch 'main' into feat/programmatic_sc_attachement
jamescrosswell 2c1ac57
Format code
getsentry-bot b939b49
clean up | remove comment on self explanatory code
bricefriha 5d8b520
clean up - Remove comments on self explanatory code
bricefriha 4517762
Unit tests - MAUI | add SetBeforeCapture in the API approvaltestrun v…
bricefriha 94b6e2e
Unit test - maui | update ApiApprovalTests.Run.DotNet7_0.verified.txt
bricefriha c5a4ba7
MAUI options - option | rename "SetBeforeCapture" -> "SetBeforeScree…
bricefriha d1d3104
Device tests - MAUI Options | setup tests for all `BeforeCaptureScree…
bricefriha 4ac2276
Unit test - MAUI option | update tests for BeforeCaptureScreenshots
bricefriha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.