fix: Marked SentrySdk.Metrics as obsolete
#3619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
SentrySdk.Metrics as obsolete
| Metrics.FlushAsync().ContinueWith(_ => | ||
| CurrentClient.FlushAsync(_options.ShutdownTimeout).ConfigureAwait(false).GetAwaiter().GetResult() | ||
| ).ConfigureAwait(false).GetAwaiter().GetResult(); | ||
| CurrentClient.FlushAsync(_options.ShutdownTimeout).ConfigureAwait(false).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Are we marking it as obsolete or removing the functionality in this PR? This change is removing metrics functionality right?
There was a problem hiding this comment.
Ah, I see in the PR description:
While marking the API as obsolete I also removed the shutdown flushing. I think it's fairly low risk and it fixes the deadlocking situation in getsentry/sentry-unity#1779
jamescrosswell
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
Closed
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Metrics Deprecation #3597
While marking the API as obsolete I also removed the shutdown flushing. I think it's fairly low risk and it fixes the deadlocking situation in getsentry/sentry-unity#1779