Skip to content

Chore: .net8 native interop cleanups #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2023
Merged

Chore: .net8 native interop cleanups #2893

merged 2 commits into from
Nov 23, 2023

Conversation

@vaind
Copy link
Collaborator

@vaind vaind commented Nov 23, 2023 •
edited
Loading

  • exclude native sources everywhere except - we don't need to build/include them elsewhere
  • clean up transitive builds to only reference native lib when needed.

#skip-changelog

@vaind vaind changed the title Chore: exclude native sources everywhere except .net8 Chore: .net8 native interop cleanups Nov 23, 2023
@vaind vaind marked this pull request as ready for review November 23, 2023 10:56
@vaind vaind merged commit c179895 into feat/4.0.0 Nov 23, 2023
@vaind vaind deleted the chore/exclude-native-cs branch November 23, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaind @bitsandfoxes