Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ without native/platform specific bindings and SDKs. See [this ticket for more de

- Drop .NET 6 Mobile in favor of .NET 7 ([#2624](https://github.com/getsentry/sentry-dotnet/pull/2604))

API Changes:

- Removed ISpanContext ([#2668](https://github.com/getsentry/sentry-dotnet/pull/2668))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect the end user in any way? Doesn't seem so, but worth being clear here.

At the end of the day we'll need a migration guide so users know what steps users need to take in order to upgrade the SDK. So when we say a type was removed, they might expect: "Ok what do I need to do to replace it?". In this case it's possibly just "This type had no documented use and if somehow you used it, it can be replaced with ITraceContext" or something like that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll try to paraphrase that in the changelog for now... and put a bit more detail in the PR notes that we can use when preparing the migration guide proper.


### Features

- Sentry tracing middleware now gets configured automatically ([#2602](https://github.com/getsentry/sentry-dotnet/pull/2602))
Expand Down
10 changes: 0 additions & 10 deletions src/Sentry/ISpanContext.cs

This file was deleted.

4 changes: 3 additions & 1 deletion src/Sentry/ISpanData.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Sentry.Protocol;

namespace Sentry;

/// <summary>
/// Immutable data belonging to a span.
/// </summary>
public interface ISpanData : ISpanContext, IHasTags, IHasExtra
public interface ISpanData : ITraceContext, IHasTags, IHasExtra
{
/// <summary>
/// Start timestamp.
Expand Down
4 changes: 3 additions & 1 deletion src/Sentry/ITransactionContext.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Sentry.Protocol;

namespace Sentry;

/// <summary>
/// Transaction metadata.
/// </summary>
public interface ITransactionContext : ISpanContext
public interface ITransactionContext : ITraceContext
{
/// <summary>
/// Transaction name.
Expand Down
4 changes: 3 additions & 1 deletion src/Sentry/SpanContext.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Sentry.Protocol;

namespace Sentry;

/// <summary>
/// Span metadata used for sampling.
/// </summary>
public class SpanContext : ISpanContext
public class SpanContext : ITraceContext
{
/// <inheritdoc />
public SpanId SpanId { get; }
Expand Down