Merged IHasTransactionNameSource into ITransactionContext #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
jamescrosswell
changed the title
…github.com/getsentry/sentry-dotnet into feat/4.0.0-remove-hastransactionnamesource
jamescrosswell
changed the title
jamescrosswell
changed the title
bruno-garcia
approved these changes
Sep 26, 2023
Member
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
LGTM! Also worht adjusting the changelog as described in the other PRs. Clarifying that this type was deleted but its member is not added to ITransaction etc.
jamescrosswell
changed the title
jamescrosswell
deleted the
feat/4.0.0-remove-hastransactionnamesource
branch
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #2629
Migration notes
The
IHasTransactionNameSourceinterface has been removed and theNameSourceproperty has been moved toITransactionContextinstead.