FormatException when enabling NativeOptions.EnableBeforeSend

[jamescrosswell]

Originally posted by @phunkeler in #3549

I tried enabling the EnableBeforeSend Android option but was met by the following exception that seemed to prevent other events from reaching Sentry.

C# Code

#if ANDROID
options.Native.EnableBeforeSend = true;
#endif

options.SetBeforeSend((sentryEvent, sentryHint) =>
{
    if (sentryAttachmentProvider.GetLogAttachment() is LogAttachment logAttachment)
    {
        sentryHint.Attachments.Add(logAttachment);
    }
    return sentryEvent;
});

Sentry Exception

System.FormatException: One of the identified items was in an invalid format.
  File "ThrowHelper.cs", line 594, in void ThrowHelper.ThrowFormatException()
    throw new FormatException { Source = ExceptionSourceValueToRethrowAsJsonException };
  File "JsonElement.cs", line 660, in int JsonElement.GetInt32()
    ThrowHelper.ThrowFormatException();
  File "Device.cs", line 459, in Device Device.FromJson(JsonElement json)
    var processorFrequency = json.GetPropertyOrNull("processor_frequency")?.GetInt32();
  File "SentryContexts.cs", line 148, in SentryContexts SentryContexts.FromJson(JsonElement json)
    result[name] = Device.FromJson(value);
  File "MiscExtensions.cs", line 5, in SentryContexts MiscExtensions.Pipe<JsonElement, SentryContexts>(JsonElement input, Func<JsonElement, SentryContexts> pipe)
    public static TOut Pipe<TIn, TOut>(this TIn input, Func<TIn, TOut> pipe) => pipe(input);
  File "SentryEvent.cs", line 305, in SentryEvent SentryEvent.FromJson(JsonElement json, Exception exception)
    var contexts = json.GetPropertyOrNull("contexts")?.Pipe(SentryContexts.FromJson);
  File "SentryEventExtensions.cs", line 29, in SentryEvent SentryEventExtensions.ToSentryEvent(SentryEvent sentryEvent, SentryOptions javaOptions)
    return SentryEvent.FromJson(json.RootElement, sentryEvent.Throwable);
  File "BeforeSendCallback.cs", line 26, in SentryEvent BeforeSendCallback.Execute(SentryEvent e, Hint h)
    var evnt = e.ToSentryEvent(_javaOptions);
  ?, in IntPtr IBeforeSendCallbackInvoker.n_Execute_Lio_sentry_SentryEvent_Lio_sentry_Hint_(IntPtr jnienv, IntPtr native__this, IntPtr native_p0, IntPtr native_p1)
  File "/Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs", line 231, col 5, in IntPtr JNINativeWrapper.Wrap_JniMarshal_PPLL_L(_JniMarshal_PPLL_L callback, IntPtr jnienv, IntPtr klazz, IntPtr p0, IntPtr p1)

[bitsandfoxes]

We might have already fixed that in #3541 and it's part of the 4.10.1 release.

[jamescrosswell]

We might have already fixed that in #3541 and it's part of the 4.10.1 release.

There's something weird going on. In the initial issue that @phunkeler created, he indicated he was using 4.10.2 but the stack trace above includes source code that doesn't look like it has the fix applied:

File "Device.cs", line 459, in Device Device.FromJson(JsonElement json)
var processorFrequency = json.GetPropertyOrNull("processor_frequency")?.GetInt32();

The change log for the 4.10.2 release doesn't appear to include that fix either:
https://github.com/getsentry/sentry-dotnet/blob/4.10.2/CHANGELOG.md

PR #3541 that included this fix this was merged 5 on August 24th however the 4.10.2 release was made August 21st.

So I think our change log got broken - that fix is still unreleased.

[phunkeler]

When I posted #3549 (comment) I was using the 4.10.0 release (from a different app than what #3549 initially used). I just tried this again using 4.10.2 and had success -- no exception and a correctly executed callback.

So, I think we're all good here.

Sorry for the confusion @jamescrosswell

[jamescrosswell]

Great thanks @phunkeler ! That's even more more mysterious but we'll put out a new 4.10.3 release in any case since it doesn't look like that fix has been released yet.