Identifying Users with OpenTelemetry doesn't work

[ldalonzo]

Package

Sentry

.NET Flavor

.NET Core

.NET Version

7.0.0

OS

Windows

SDK Version

3.39.1

Self-Hosted Sentry Version

No response

Steps to Reproduce

1. Instrument an ASP.NET Core with Sentry.OpenTelemetry
2. Configure Sentry to opt-in for SendDefaultPii
3. Register a custom IUserFactory to populate the sentry username

Expected Result

The custom user factory gets called and the username is reported to Sentry

Actual Result

The custom IUserFactory is never called. Only the IP address is reported to Sentry.
A similar behaviour applies when setting the username through the hub's ConfigureScope method.

[bruno-garcia]

For context, came up from: https://stackoverflow.com/questions/58858092/sentry-sdk-dotnet-core-not-using-iuserfactory/58868882?noredirect=1#comment135908613_58868882

[jamescrosswell]

Hi @ldalonzo, thanks for raising a ticket for this. I can reproduce this easily enough, so we should be able to come up with a solution.

It doesn't necessarily require a custom IUserFactory either... we see the same behaviour using the DefaultUserFactory.

When not using OpenTelemetry, this is enabled via our SentryMiddleware:

sentry-dotnet/src/Sentry.AspNetCore/SentryMiddleware.cs

Lines 107 to 123 in 55ca61e

	hub.ConfigureScope(scope =>
	{
	// At the point lots of stuff from the request are not yet filled
	// Identity for example is added later on in the pipeline
	// Subscribing to the event so that HTTP data is only read in case an event is going to be
	// sent to Sentry. This avoid the cost on error-free requests.
	// In case of event, all data made available through the HTTP Context at the time of the
	// event creation will be sent to Sentry
	// Important: The scope that the event is attached to is not necessarily the same one that is active
	// when the event fires. Use `activeScope`, not `scope` or `hub`.
	scope.OnEvaluating += (_, activeScope) =>
	{
	SyncOptionsScope(activeScope);
	PopulateScope(context, activeScope);
	};
	});

Sentry.OpenTelemetry is agnostic of the application type being deployed... so it doesn't know about things like Microsoft.AspNetCore.Http.HttpContext, that only exist in ASP.NET Core.

@bruno-garcia @bitsandfoxes fyi - a bit of a pain but I think to make this work I'll have to add a Sentry.OpenTelemery.AspNetCore package that takes dependencies on Microsoft.AspNetCore.Http (so we can get at the HttpContext.