-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(apple): Add session replay trouble shooting page with custom window handling #13753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 1.31kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
…eplay-scene-delegate
docs/platforms/apple/guides/ios/session-replay/troubleshooting.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can detect this in the SDK. So basically, if we can't find the window. Maybe it makes sense to print the link to the docs in the SDK warning or error log?
LGTM
@@ -0,0 +1,71 @@ | |||
--- | |||
title: Troubleshooting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: I think we should add a link to this troubleshooting guide from https://docs.sentry.io/platforms/apple/troubleshooting/, so people can find it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll do that.
I believe I didn't do this before, because it's also possible that the window will be created afterwards: I would have to add the log statement here, with a detection if the window should already be there, e.g. checking the app state. I'll create another issue in sentry-cocoa for this. |
DESCRIBE YOUR PR
During debugging of the SDK we discovered that session replay for iOS requires on the
window
property of the window scene delegate /UIWindowSceneDelegate
to be set. By default this will be set during the bootstrapping of the app, but it appears that the property can also be omitted and not configured.This PR adds documentation to indicate to users how to deal with this. It's also the start of having a troubleshooting section dedicated to session replay:
https://sentry-docs-git-philprime-session-replay-scene-delegate.sentry.dev/platforms/apple/guides/ios/session-replay/troubleshooting/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES