Refactor app hang and native crash apis to FFI/JNI #3289

buenaflor · 2025-10-09T13:16:56Z

📜 Description

Part of FFI/JNI refactors

💡 Motivation and Context

Closes #3207

💚 How did you test it?

Unit test, manual tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

denrase

LGTM 👍

…fi-jni-refactor

denrase

Looks good, but saw that the nativeCrash method was modified in #3293, just making sure this all fits together.

buenaflor · 2025-10-20T07:59:06Z

Looks good, but saw that the nativeCrash method was modified in #3293, just making sure this all fits together.

yup, update it here as well

cursor · 2025-10-23T10:12:03Z

Bug: Swift Compiler Errors Due to Method Duplication

The "Objective-C interoperability" section, including getDisplayRefreshRate(), onDisplayLinkStatic(), and fetchNativeAppStartAsBytes(), is duplicated in SentryFlutterPlugin.swift. This redeclaration of methods will cause Swift compiler errors.

github-actions · 2025-10-23T10:18:22Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	365.85 ms	396.85 ms	31.00 ms
Size	13.93 MiB	15.06 MiB	1.13 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8825ed8`	447.65 ms	456.90 ms	9.25 ms
`793f4dc`	462.68 ms	544.21 ms	81.53 ms
`54acf91`	487.24 ms	529.60 ms	42.36 ms
`1f639ee`	429.98 ms	476.60 ms	46.62 ms
`c1e775e`	482.36 ms	608.98 ms	126.62 ms
`944b773`	470.54 ms	480.18 ms	9.64 ms
`0929dbf`	462.82 ms	492.76 ms	29.94 ms
`827bf09`	475.40 ms	547.14 ms	71.74 ms
`4298701`	524.40 ms	633.30 ms	108.90 ms
`6b69699`	456.06 ms	557.44 ms	101.38 ms

App size

Revision	Plain	With Sentry	Diff
`8825ed8`	13.93 MiB	14.93 MiB	1.00 MiB
`793f4dc`	6.54 MiB	7.69 MiB	1.15 MiB
`54acf91`	6.54 MiB	7.70 MiB	1.17 MiB
`1f639ee`	13.93 MiB	15.00 MiB	1.06 MiB
`c1e775e`	6.54 MiB	7.70 MiB	1.17 MiB
`944b773`	13.93 MiB	15.00 MiB	1.06 MiB
`0929dbf`	6.54 MiB	7.70 MiB	1.17 MiB
`827bf09`	6.54 MiB	7.53 MiB	1015.27 KiB
`4298701`	6.54 MiB	7.71 MiB	1.17 MiB
`6b69699`	6.54 MiB	7.70 MiB	1.17 MiB

Previous results on branch: enh/app-hang-ffi-jni-refactor

Startup times

Revision	Plain	With Sentry	Diff
`c40ff0c`	456.43 ms	443.54 ms	-12.89 ms
`e80304a`	504.83 ms	503.18 ms	-1.65 ms
`7538a1c`	497.43 ms	486.44 ms	-10.99 ms
`f881241`	463.64 ms	461.08 ms	-2.56 ms
`714279e`	485.55 ms	529.50 ms	43.95 ms
`5abe802`	468.98 ms	481.62 ms	12.64 ms
`3af23cc`	508.42 ms	505.73 ms	-2.69 ms
`aacf1ff`	429.09 ms	441.14 ms	12.05 ms

App size

Revision	Plain	With Sentry	Diff
`c40ff0c`	13.93 MiB	15.06 MiB	1.13 MiB
`e80304a`	13.93 MiB	15.06 MiB	1.13 MiB
`7538a1c`	13.93 MiB	15.06 MiB	1.13 MiB
`f881241`	13.93 MiB	15.06 MiB	1.13 MiB
`714279e`	13.93 MiB	15.06 MiB	1.13 MiB
`5abe802`	13.93 MiB	15.06 MiB	1.13 MiB
`3af23cc`	13.93 MiB	15.06 MiB	1.13 MiB
`aacf1ff`	13.93 MiB	15.06 MiB	1.13 MiB

github-actions · 2025-10-23T10:42:59Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1256.89 ms	1262.47 ms	5.58 ms
Size	5.53 MiB	6.01 MiB	488.11 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`819c1e7`	1250.59 ms	1249.08 ms	-1.51 ms
`e2d675d`	1238.48 ms	1242.76 ms	4.28 ms
`9b99523`	1256.06 ms	1270.33 ms	14.27 ms
`c8596a6`	1234.11 ms	1241.19 ms	7.08 ms
`54acf91`	1257.65 ms	1277.96 ms	20.31 ms
`5b9a0da`	1249.69 ms	1250.71 ms	1.03 ms
`c1e775e`	1263.08 ms	1275.32 ms	12.24 ms
`4481076`	1256.48 ms	1266.64 ms	10.17 ms
`7b21e8b`	1256.79 ms	1267.12 ms	10.33 ms
`de377fd`	1252.28 ms	1254.76 ms	2.48 ms

App size

Revision	Plain	With Sentry	Diff
`819c1e7`	5.53 MiB	6.00 MiB	479.96 KiB
`e2d675d`	7.86 MiB	9.44 MiB	1.58 MiB
`9b99523`	7.86 MiB	9.44 MiB	1.58 MiB
`c8596a6`	7.86 MiB	9.44 MiB	1.58 MiB
`54acf91`	20.70 MiB	22.46 MiB	1.75 MiB
`5b9a0da`	5.53 MiB	5.96 MiB	444.32 KiB
`c1e775e`	20.70 MiB	22.46 MiB	1.75 MiB
`4481076`	7.86 MiB	9.44 MiB	1.58 MiB
`7b21e8b`	5.53 MiB	6.00 MiB	479.96 KiB
`de377fd`	20.71 MiB	22.43 MiB	1.73 MiB

Previous results on branch: enh/app-hang-ffi-jni-refactor

Startup times

Revision	Plain	With Sentry	Diff
`3af23cc`	1255.66 ms	1265.28 ms	9.62 ms
`7538a1c`	1246.86 ms	1249.00 ms	2.14 ms
`f881241`	1249.80 ms	1251.20 ms	1.41 ms
`dc580bb`	1258.85 ms	1262.65 ms	3.81 ms
`e80304a`	1255.63 ms	1259.80 ms	4.16 ms
`c40ff0c`	1240.31 ms	1244.87 ms	4.56 ms
`5abe802`	1235.16 ms	1250.37 ms	15.21 ms
`aacf1ff`	1255.85 ms	1261.44 ms	5.58 ms
`ab8fd7f`	1260.59 ms	1253.57 ms	-7.02 ms
`714279e`	1269.35 ms	1267.37 ms	-1.97 ms

App size

Revision	Plain	With Sentry	Diff
`3af23cc`	5.53 MiB	6.00 MiB	485.45 KiB
`7538a1c`	5.53 MiB	6.00 MiB	485.45 KiB
`f881241`	5.53 MiB	6.00 MiB	485.45 KiB
`dc580bb`	5.53 MiB	6.01 MiB	488.11 KiB
`e80304a`	5.53 MiB	6.00 MiB	485.46 KiB
`c40ff0c`	5.53 MiB	6.00 MiB	485.45 KiB
`5abe802`	5.53 MiB	6.00 MiB	487.14 KiB
`aacf1ff`	5.53 MiB	6.00 MiB	487.13 KiB
`ab8fd7f`	5.53 MiB	6.01 MiB	488.12 KiB
`714279e`	5.53 MiB	6.00 MiB	487.14 KiB

buenaflor and others added 30 commits September 3, 2025 01:25

Update

03f8118

Update

6928f3a

Update

a91cbae

Update

a6bd3cc

Update

b9269c7

Update

6ef9960

Configure diagnostic log

a43f2e1

Update log messages

e334269

Update

aa728e7

Update

45cc8c3

Update

a603960

Update

147da01

Update

2b11149

Update

8325952

Update

3dbe751

Update

71ba593

Update

fe7f6df

Update

39a951e

Fix test

884642f

Update

f5f5401

Update

de232c6

Update

69d5111

Merge branch 'main' into enh/long-lived-envelope-worker

79d9ff9

Add automatedTestMode option

62bb12b

Merge branch 'main' into enh/long-lived-envelope-worker

532d2b3

Update

53c6036

Fix web tests

06ee227

Update

10d9419

Update

e6771bb

Add close

e2ae6a3

Update

1ffba6f

denrase approved these changes Oct 14, 2025

View reviewed changes

buenaflor added 2 commits October 14, 2025 13:03

Merge branch 'enh/app-start-refresh-rate-jni-ffi' into enh/app-hang-f…

f881241

…fi-jni-refactor

Merge branch 'main' into enh/app-start-refresh-rate-jni-ffi

9733bc8

buenaflor force-pushed the enh/app-hang-ffi-jni-refactor branch from 7538a1c to f881241 Compare October 16, 2025 12:27

Update

fce96c7

This comment was marked as outdated.

Sign in to view

buenaflor and others added 9 commits October 16, 2025 15:06

Update

958fa0d

Update

84542ab

Update

e744a5e

Update

9912628

Update

dee9256

Update

ab2f4e9

Update

ed51094

Update

0d378b3

Merge branch 'enh/app-start-refresh-rate-jni-ffi' into enh/app-hang-f…

5abe802

…fi-jni-refactor

denrase approved these changes Oct 18, 2025

View reviewed changes

Update

aacf1ff

Update

714279e

Base automatically changed from enh/app-start-refresh-rate-jni-ffi to main October 22, 2025 21:39

Merge branch 'main' into enh/app-hang-ffi-jni-refactor

ab8fd7f

Update

dc580bb

buenaflor added 2 commits October 23, 2025 12:18

Update

3b4c2d3

Update

e82e153

buenaflor merged commit ad121c0 into main Oct 23, 2025
52 of 54 checks passed

buenaflor deleted the enh/app-hang-ffi-jni-refactor branch October 23, 2025 12:03

Uh oh!

Refactor app hang and native crash apis to FFI/JNI #3289

Refactor app hang and native crash apis to FFI/JNI #3289

Uh oh!

Conversation

buenaflor commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

denrase left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

denrase left a comment

Choose a reason for hiding this comment

Uh oh!

buenaflor commented Oct 20, 2025

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Swift Compiler Errors Due to Method Duplication

Uh oh!

github-actions bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/app-hang-ffi-jni-refactor

Startup times

App size

Uh oh!

github-actions bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/app-hang-ffi-jni-refactor

Startup times

App size

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

buenaflor commented Oct 9, 2025 •

edited

Loading

github-actions bot commented Oct 23, 2025 •

edited

Loading

github-actions bot commented Oct 23, 2025 •

edited

Loading