Skip to content

SentryUserInteractionWidget checks if the Elements are mounted before comparing them #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2023
Merged

SentryUserInteractionWidget checks if the Elements are mounted before comparing them #1339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cac1e4d
SentryUserInteractionWidget checks if the Elements are mounted before…
marandaneto Mar 16, 2023
7ddcddd
Update CHANGELOG.md
marandaneto Mar 16, 2023
8482f60
fix
marandaneto Mar 16, 2023
0b7d785
Merge branch 'fix/last-element-mounted' of github.com:getsentry/sentr…
marandaneto Mar 17, 2023
3efafd1
make it a method
marandaneto Mar 17, 2023
24593e6
make Flutter v3 compatible
marandaneto Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#831)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.0.0...8.3.1)

### Fixes

- SentryUserInteractionWidget checks if the Elements are mounted before comparing them ([#1181](https://github.com/getsentry/sentry-dart/pull/1181))

## 7.0.0

### Features
Expand Down
5 changes: 4 additions & 1 deletion flutter/lib/src/user_interaction/sentry_user_interaction_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,11 @@ class _SentryUserInteractionWidgetState
);

final activeTransaction = _activeTransaction;
final lastElement = _lastTappedWidget?.element;
if (activeTransaction != null) {
if (_lastTappedWidget?.element.widget == element.widget &&
if (lastElement?.mounted == true &&
element.mounted &&
lastElement?.widget == element.widget &&
_lastTappedWidget?.eventType == tappedWidget.eventType &&
!activeTransaction.finished) {
// ignore: invalid_use_of_internal_member
Expand Down