Structured Logs: Add `SentrySwiftLog` Integration #6286

denrase · 2025-09-25T14:24:47Z

📜 Description

The Sentry swift-log integration.

Setup

Adds SentrySwiftLog as a target to Sentry target
Adds SentrySwiftLog to Package.swift
Add a sample call to the iOS15-SwiftUi app so you can play around with it

Implementation

Adds SentryLogHandler
sentry-log metadata is mapped to attributes and prefixed with swift-log
Other parameters of the log function are set as attributes and

Discussion

Here vs Own Repo

Added the integration to this repo, because it is easier for us to maintain.

On the swift-log repo integrations section is linking to the swift package index with search term swift-log. So for visibility, we'd need to have a separate swift-log-sentry repo.

https://github.com/apple/swift-log?tab=readme-ov-file#available-log-handler-backends
https://swiftpackageindex.com/search?query=swift-log

Distribution

Only distributed through SPM, as swift-log dropped support for CocoaPods. Also, we'll not be able to distribute this as a binary, as swift-log is not supporting that.

Module was not compiled with library evolution support; using it means binary compatibility for can't be guaranteed

💡 Motivation and Context

Closes #5372

💚 How did you test it?

Unit Tests
Sample App

📝 Checklist

You have to check all boxes before merging:

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

codecov · 2025-09-25T14:28:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@939d583). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff            @@
##             main     #6286   +/-   ##
========================================
  Coverage        ?   85.153%           
========================================
  Files           ?       452           
  Lines           ?     27657           
  Branches        ?     12120           
========================================
  Hits            ?     23551           
  Misses          ?      4060           
  Partials        ?        46

Files with missing lines	Coverage Δ
SentryTestUtils/Sources/ClearTestState.swift	`86.000% <100.000%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939d583...7d64f52. Read the comment docs.

github-actions · 2025-09-25T15:14:00Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1209.85 ms	1247.02 ms	37.17 ms
Size	23.75 KiB	1023.82 KiB	1000.07 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d66f082`	1227.08 ms	1247.04 ms	19.96 ms
`09471ff`	1239.98 ms	1256.65 ms	16.67 ms
`fc0757d`	1231.83 ms	1248.98 ms	17.15 ms
`1bf432b`	1200.22 ms	1226.90 ms	26.67 ms
`b6f8eb3`	1217.94 ms	1246.57 ms	28.63 ms
`2ec2700`	1238.28 ms	1258.82 ms	20.53 ms
`52603c5`	1226.94 ms	1257.66 ms	30.72 ms
`409a607`	1229.57 ms	1251.45 ms	21.88 ms
`7d88965`	1228.86 ms	1248.53 ms	19.67 ms
`2be5991`	1228.55 ms	1264.65 ms	36.10 ms

App size

Revision	Plain	With Sentry	Diff
`d66f082`	23.75 KiB	928.85 KiB	905.10 KiB
`09471ff`	23.75 KiB	990.16 KiB	966.41 KiB
`fc0757d`	23.75 KiB	850.73 KiB	826.98 KiB
`1bf432b`	23.75 KiB	926.64 KiB	902.90 KiB
`b6f8eb3`	23.75 KiB	988.70 KiB	964.95 KiB
`2ec2700`	23.75 KiB	980.80 KiB	957.05 KiB
`52603c5`	23.75 KiB	969.78 KiB	946.03 KiB
`409a607`	23.74 KiB	874.08 KiB	850.33 KiB
`7d88965`	23.75 KiB	994.72 KiB	970.98 KiB
`2be5991`	23.75 KiB	994.73 KiB	970.98 KiB

Previous results on branch: denrase/swift-log-sentry-poc

Startup times

Revision	Plain	With Sentry	Diff
`0fd08ab`	1225.14 ms	1256.49 ms	31.35 ms
`f23a1b4`	1226.17 ms	1264.55 ms	38.38 ms
`b52b178`	1227.86 ms	1255.65 ms	27.79 ms
`2bd1339`	1223.22 ms	1248.85 ms	25.64 ms
`53379e0`	1231.19 ms	1269.38 ms	38.20 ms
`6245148`	1229.77 ms	1269.93 ms	40.17 ms

App size

Revision	Plain	With Sentry	Diff
`0fd08ab`	23.75 KiB	995.43 KiB	971.68 KiB
`f23a1b4`	23.75 KiB	1.01 MiB	1016.14 KiB
`b52b178`	23.75 KiB	989.97 KiB	966.22 KiB
`2bd1339`	23.75 KiB	1.01 MiB	1006.48 KiB
`53379e0`	23.75 KiB	1.00 MiB	1002.40 KiB
`6245148`	23.75 KiB	1023.82 KiB	1000.07 KiB

# Conflicts: # Package.swift # Sentry.xcodeproj/project.pbxproj

itaybre

Looks good, just a small comment

itaybre · 2025-10-10T20:52:23Z

.github/actions/prepare-package.swift/action.yml

+        # Clean up orphaned commas and fix syntax
+        sed -i '' '/^[[:space:]]*,$/d' $PACKAGE_FILE
+        sed -i '' 's/name: "Sentry\(-.*\)\?"$/name: "Sentry\1",/g' $PACKAGE_FILE
+        sed -i '' 's/platforms: \[\.iOS(\.v11), \.macOS(\.v10_13), \.tvOS(\.v11), \.watchOS(\.v4)\]$/platforms: [.iOS(.v11), .macOS(.v10_13), .tvOS(.v11), .watchOS(.v4)],/g' $PACKAGE_FILE


What is this trying to do?

One of the CI jobs is replacing dependencies with local build artefacts. This broke, as swift-log was added to our Package.swift. This code fixes those issues.

Does this only happen because of swift-log or should we do the fix in a separate PR?

Only because of swift-log dependency added in our Package.swift

philprime · 2025-10-20T11:38:27Z

Package.swift

    .library(name: "SentrySwiftUI", targets: ["Sentry", "SentrySwiftUI", "SentryCppHelper"]),
-    .library(name: "SentryDistribution", targets: ["SentryDistribution"])
+    .library(name: "SentryDistribution", targets: ["SentryDistribution"]),
+    .library(name: "SentrySwiftLog", targets: ["Sentry", "SentrySwiftLog"])


m: I don't fully understand why this is another target. Is this only here because swift-log is a new dependency? Shouldn't we add it as a dependency to Sentry instead?

The intent was to only pull in the dependency for users that actually are using swift-log, but then again, I am not sure how this would behave if a user is not using SentrySwiftLog target. Will check.

Ok, there is a proposal that was partially adopted:

https://github.com/swiftlang/swift-evolution/blob/main/proposals/0226-package-manager-target-based-dep-resolution.md

I created a sample app with a similar setup. While SPM will always resolve the dependency, it will bot be linked/build if it is not required by the target.

So this setup works as expected.

Package.swift

CHANGELOG.md

# Conflicts: # Sentry.xcodeproj/project.pbxproj

# Conflicts: # Package.swift # Sentry.xcodeproj/project.pbxproj

denrase added 7 commits September 25, 2025 13:24

POC: Add swift-log package

a72802e

Merge branch 'main' into denrase/swift-log-sentry-poc

7032e87

use trace instead of error in sample app

4b491c8

add tests, move sample to app with ios > 11

21dc2de

revert changes in sample app

59117a4

remove unused helper

2fcf8bb

no need for docs for swift-log methods

467f314

denrase added 4 commits September 25, 2025 16:28

fix typo

00559c2

no need to map level

249759b

fix typo

1c0a0d4

format package

39dc722

denrase added 4 commits September 30, 2025 14:03

Merge branch 'main' into denrase/swift-log-sentry-poc

3f82bb0

# Conflicts: # Package.swift # Sentry.xcodeproj/project.pbxproj

Rename to SentrySwiftLog

ce69ea1

remae target

825e5df

Add changelog

7139756

denrase changed the title ~~Structured Logs: swift-log Integration~~ Structured Logs: Add SentrySwiftLog Integration Sep 30, 2025

denrase added 8 commits September 30, 2025 14:40

disable lint warning, remove todo

2408a07

Exclude from SentryObjc

f9062d6

test SentrySwiftLog

f6bc914

Update prepare-package.swift

fd73f1e

Add shared scheme

fb07770

Merge branch 'main' into denrase/swift-log-sentry-poc

befdf40

fix old target names

45c8ed8

format

0779263

denrase marked this pull request as ready for review October 1, 2025 13:25

denrase requested review from noahsmartin, philipphofmann and philprime as code owners October 1, 2025 13:26

This comment was marked as outdated.

Sign in to view

add cl entry

3d57dc6

itaybre reviewed Oct 10, 2025

View reviewed changes

denrase requested a review from itaybre October 13, 2025 14:31

philprime reviewed Oct 20, 2025

View reviewed changes

Package.swift Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

denrase added 6 commits October 22, 2025 11:28

Merge branch 'main' into denrase/swift-log-sentry-poc

3a4fec5

cleanup changelog

6e50913

Merge branch 'main' into denrase/swift-log-sentry-poc

36cf96c

# Conflicts: # Sentry.xcodeproj/project.pbxproj

Merge branch 'main' into denrase/swift-log-sentry-poc

cbd54d6

disable automatic signing

c9356f5

remove auto code signing

3063011

denrase requested a review from philprime October 22, 2025 13:10

denrase added 3 commits October 28, 2025 14:06

Merge branch 'main' into denrase/swift-log-sentry-poc

150ecfc

Merge branch 'main' into denrase/swift-log-sentry-poc

f376191

# Conflicts: # Sentry.xcodeproj/project.pbxproj

Merge branch 'main' into denrase/swift-log-sentry-poc

476a3d6

This comment was marked as outdated.

Sign in to view

denrase added 5 commits November 4, 2025 11:20

Merge branch 'main' into denrase/swift-log-sentry-poc

510af71

# Conflicts: # Package.swift # Sentry.xcodeproj/project.pbxproj

update changelog

d04e56a

add comments to package and decisions

dcefd41

fix threshold implementation

8a49b9a

Merge branch 'main' into denrase/swift-log-sentry-poc

48f673b

This comment was marked as outdated.

Sign in to view

denrase added 7 commits November 4, 2025 14:32

remove shared scheme (not needed for runnign tests after all)

efebbf5

Merge branch 'main' into denrase/swift-log-sentry-poc

81cc0de

cleanup project file

c66cee2

update test.yml

234b64a

fix „bloated“ pbxproj file by adding shared xcconfig

b1bda95

udate

8b90e4f

Merge branch 'main' into denrase/swift-log-sentry-poc

7d64f52

Uh oh!

Structured Logs: Add SentrySwiftLog Integration #6286

Are you sure you want to change the base?

Structured Logs: Add SentrySwiftLog Integration #6286

Conversation

denrase commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

Setup

Implementation

Discussion

Here vs Own Repo

Distribution

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

Uh oh!

codecov bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: denrase/swift-log-sentry-poc

Startup times

App size

Uh oh!

This comment was marked as outdated.

Uh oh!

itaybre left a comment

Choose a reason for hiding this comment

Uh oh!

itaybre Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

denrase Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

philprime Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

denrase Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

philprime Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

denrase Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

denrase Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Structured Logs: Add `SentrySwiftLog` Integration #6286

Structured Logs: Add `SentrySwiftLog` Integration #6286

denrase commented Sep 25, 2025 •

edited

Loading

codecov bot commented Sep 25, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited

Loading