ref(processor): Move more functions #5322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Oct 31, 2025
| project_id: ProjectId, | ||
| ctx: processing::Context<'_>, | ||
| geo_lookup: &GeoIpLookup, | ||
| reservoir_counters: &ReservoirEvaluator<'_>, |
Member
Author
There was a problem hiding this comment.
This argument was passed into the function but was disabled by supports_reservoir_sampling on the Sampled trait.
| ) | ||
| .await; | ||
| // If no metrics could be extracted, do not sample anything. | ||
| let should_sample = matches!(&ctx.project_info.config().metric_extraction, ErrorBoundary::Ok(c) if c.is_supported()); |
Member
Author
There was a problem hiding this comment.
This check was previously evaluated in supports_sampling in the Sampling trait.
| // Also, we require transaction metrics to be enabled before sampling. | ||
| let run_dynamic_sampling = (matches!(filter_run, FiltersStatus::Ok) | ||
| || self.inner.config.processing_enabled()) | ||
| && matches!(&ctx.project_info.config.transaction_metrics, Some(ErrorBoundary::Ok(c)) if c.is_enabled()); |
Member
Author
There was a problem hiding this comment.
This check was previously defined in Sampled::supports_sampling.
Dav1dde
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in #5309, refactor processing helpers to not depend on envelopes / the processor service itself, and move them to
processing.ref: INGEST-610