-
Notifications
You must be signed in to change notification settings - Fork 103
feat(ourlogs): Adjust 'log' protocol per sdk feedback #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
69b8290
feat(ourlogs): Adjust 'log' protocol per sdk feedback
k-fish 5a9ed62
Merge remote-tracking branch 'origin/master' into feat/ourlogs/adjust…
k-fish c978f79
Switch to using flattened structure in the protocol
k-fish 469a4dd
Rm dead code
k-fish e93ce63
Add structs for LogKafkaMessage to fix serialization of attributes
k-fish a70e22c
Get processing working
k-fish 502dd19
Update relay-event-schema/src/protocol/ourlog.rs
k-fish 981b73e
Update relay-event-schema/src/protocol/ourlog.rs
k-fish a3378de
Fix tests
k-fish e2c32e0
Fix types to match spec
k-fish d853843
Fill out the rest of the types in tests and check for forward compati…
k-fish c5e0539
Include 'other' in debug
k-fish 1d949ef
Fix test snapshot
k-fish 04c45fd
process attributes without clone
k-fish 77cbb01
Again without using clone
k-fish 5591034
u64 i64 for f64
k-fish defad31
minor clean ups
Dav1dde 9f35177
Update instas
k-fish 4fea352
Update severity to default to 0, include a test
k-fish 9e3ce40
Add schema processor
k-fish 1632a30
Fix tests
k-fish 53c5ce0
remove attributes instead of just type/value
Dav1dde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| use crate::processor::ProcessValue; | ||
| use relay_protocol::{Annotated, Empty, FromValue, IntoValue, Value}; | ||
|
|
||
| #[derive(Clone, Debug, Default, PartialEq, Empty, FromValue, IntoValue, ProcessValue)] | ||
| #[metastructure(trim = false)] | ||
| pub struct Attribute { | ||
| #[metastructure(field = "value", pii = "true", required = true)] | ||
| value: Annotated<Value>, | ||
| } | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Empty, FromValue, IntoValue, ProcessValue)] | ||
| pub enum AttributeValue { | ||
| String { value: Annotated<String> }, | ||
| Int { value: Annotated<i64> }, | ||
| Double { value: Annotated<f64> }, | ||
| Bool { value: Annotated<bool> }, | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.