feat(danger): Allow skipping changelog with label #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows skipping the danger changelog check with a `skip-changelog` label in addition to `#skip-changelog` in the PR description. To make sure this triggers properly, the `danger` workflow should be run on a PR being `labeled` and `unlabeled`.
|
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
vaind
approved these changes
Aug 8, 2025
Ironically I didn't think about that. |
vaind
approved these changes
Aug 8, 2025
loewenheim
added a commit
that referenced
this pull request
Aug 8, 2025
The example should mention `labeled` and `unlabeled`.
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Aug 8, 2025
As of getsentry/github-workflows#94 the `danger` workflow supports skipping the changelog check with a `skip-changelog` label. To make this work the `danger` job needs to run when a PR is labeled or unlabeled.
vaind
pushed a commit
that referenced
this pull request
Aug 9, 2025
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Aug 11, 2025
As of getsentry/github-workflows#94 the `danger` workflow supports skipping the changelog check with a `skip-changelog` label. To make this work the `danger` job needs to run when a PR is labeled or unlabeled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows skipping the danger changelog check with a
skip-changeloglabel in addition to#skip-changelogin the PR description.To make sure this triggers properly, the
dangerworkflow should be run on a PR beinglabeledandunlabeled.Closes #93.
Please feel free to close this if this functionality isn't desired.