-
Notifications
You must be signed in to change notification settings - Fork 75
Ensure parallel map Closed error propagation
#1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnhungerford
wants to merge
17
commits into
getkyo:main
Choose a base branch
from
johnhungerford:map-par-closed-bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ba853c1
Added Abort.withMask; updated ConcreteTag to derive from individual t…
johnhungerford d9b6fec
Added & using Abort.withMask
johnhungerford ae65208
Fix readme
johnhungerford 39539dc
Merge branch 'main' into map-par-closed-bug
johnhungerford a165a2c
Added comment; removed redundant Scope.ensure from Actor
johnhungerford 5545af3
Merge branch 'map-par-closed-bug' of github.com:johnhungerford/kyo in…
johnhungerford 15a0fb7
Simplified withMask; applying to stream.emit as well
johnhungerford ebfcda2
Reverted Fiber[A, Abort[Nothing]] to Fiber[A, Any]
johnhungerford 7b17349
Fixed readme
johnhungerford b4ed946
Merge remote-tracking branch 'upstream/main' into map-par-closed-bug
johnhungerford c457e87
Merge branch 'main' into map-par-closed-bug
johnhungerford ddd6844
Merge branch 'main' into map-par-closed-bug
johnhungerford e6ef026
Removed redundant mailbox finalizer
johnhungerford f91936f
Merge branch 'map-par-closed-bug' of github.com:johnhungerford/kyo in…
johnhungerford b0910c9
Formatted
johnhungerford c4bb93c
Using sync.ensure again
johnhungerford 426ab83
Merge branch 'main' into map-par-closed-bug
johnhungerford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think It'd be important to not track
Abort[Nothing]here. Sorry, I think I indicated that it'd be fine to removeReduciblefromFiber.initbut I thought this would still beAnysince the underlying impl isIOPromiseBase[Any, A < (Async & S)]but I'm not sure it's possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may still be possible to get rid of
Reduciblewithout trackingAbort[Nothing]. I'll give it a tryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can pull it off by adding a
reducemethod toFiberandFiber.Unsafe