-
Couldn't load subscription status.
- Fork 74
Kyo grpc #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
steinybot
wants to merge
227
commits into
getkyo:main
Choose a base branch
from
steinybot:kyo-grpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Kyo grpc #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Back on this again finally. I have reimplemented a lot of stuff to support metadata and backpressure. I am redoing all the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390
/claim #390
Problem
Built-in support in Kyo for gRPC.
Solution
The code generation uses paiges which I don't love. I started using Scalameta but it doesn't support comments. It is possible this has changed since then. Either way, perhaps switching back to Scalameta would be a better choice. This code got a bit funky.
This is similar to zio-grpc although their
ServerLayerandServiceListstuff seemed unnecessary.I am using the high level API. In future I'll try implementing it using
ServerCallHandlerwhich would probably give much better flow control and backpressure. It seems to still be pretty performant even without it (I need to run the benchmarks again).Notes
TODO during PR:
closeAwaitEmptyFiberTODO after PR: