Don't write ModelPixelScale, ModelTiepoint when ModelTransformationTag is present #462
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nTag is present (see specs: http://geotiff.maptools.org/spec/geotiff2.6.html)
Member
|
@DanielJDufour does this look sound to you? |
Contributor
|
Yes, looks great. Thank you @JodokGBS for catching this! Good to merge! |
DanielJDufour
approved these changes
Sep 21, 2025
TheMrCam
reviewed
Nov 18, 2025
Collaborator
TheMrCam
left a comment
TheMrCam
left a comment
There was a problem hiding this comment.
Thank you all! This looks good to me, although I would like to see an example test case which does set ModelTransformationTag so we can make sure not to regress. As it stands, I couldn't find ModelTransformationTag referenced anywhere in the tests (except an unused fetch), so that case would be valuable regardless of any issues here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs (http://geotiff.maptools.org/spec/geotiff2.6.html) ModelPixelScale and ModelTiepoint should only be there when the ModelTransformationTag is not set, so we should not automatically add them when a ModelTransformationTag is provided.