Skip to content

Conversation

@sguimmara
Copy link
Contributor

I took over @anton-seaice's PR #342.

This PR ensures that the options object is properly passed to the underlying from* builder functions (fromUrl(), fromCustomClient(), etc).

This fixes two issues:

Copy link
Collaborator

@TheMrCam TheMrCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want to pass options to makeRemoteSource in fromUrls, right? We're using the same options object for GeoTIFFOptions and for makeRemoteSource#options in fromUrl and fromCustomClient, so I'd assume we'd want the same in fromUrls.

@sguimmara sguimmara force-pushed the pass-options-to-from-builders branch from bf490ed to 72ac87e Compare November 14, 2025 10:58
Copy link
Collaborator

@TheMrCam TheMrCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I just have one final ask before I'm ready to merge this: could you add test(s) to ensure we don't cause a regression here in the future?

Something as simple as passing in a pre-cancelled signal and confirming the expected behavior would work for me—although verifying the tile cache options would be good too, so we can close both linked issues.

I somehow missed this, but we do already have an "Abort signal" suite—clearly it could be improved to pick up on those reported issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants