feat: Add version detection warnings for hot reload #41
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add warnings in all commands that use hot_reload to inform users about the known limitation on Flutter stable <= 3.37.0. This helps users understand why hot reload may fail and provides clear guidance on workarounds (switching to Flutter main channel or manually restarting the app). Changes: - Updated /debug-app command to check Flutter version early and warn users about hot reload limitations - Added inline warnings in /create-app and /modify commands when hot_reload is used - Updated CHANGELOG.md to document this improvement Related to gemini-cli-extensions#15
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of hot reload failures on older Flutter versions by adding proactive warnings. The changes are clear and well-documented in the CHANGELOG. My review focuses on ensuring the accuracy and consistency of the information provided in the new warnings.
| - **IMPORTANT**: Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0 (see [issue #15](https://github.com/gemini-cli-extensions/flutter/issues/15)) | ||
| - If the user is on Flutter stable ≤ 3.37.0, warn them that hot reload may fail during this debugging session | ||
| - Suggest they either: | ||
| 1. Switch to Flutter main/master channel for full hot reload support, OR |
There was a problem hiding this comment.
The term main/master channel could be confusing. Flutter's main development branch is master. To provide clear and accurate guidance, it's better to refer specifically to the master channel.
1. Switch to Flutter master channel for full hot reload support, OR
|
@sethladd @gspencergoog @johnpryan - Would appreciate your review on this improvement for issue #15. This PR adds proactive warnings to help users understand the hot reload limitation on Flutter stable ≤ 3.37.0, providing clear workarounds until the upstream Dart SDK fix is available. |
gspencergoog
reviewed
Oct 9, 2025
| - [ ] Run `flutter doctor` to get the Flutter and Dart SDK versions and check for any issues reported. | ||
| - [ ] Check the Flutter version output and determine if hot reload is supported: | ||
| - **IMPORTANT**: Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0 (see [issue #15](https://github.com/gemini-cli-extensions/flutter/issues/15)) | ||
| - If the user is on Flutter stable ≤ 3.37.0, warn them that hot reload may fail during this debugging session |
There was a problem hiding this comment.
I'd just delete this item in favor of the suggestion I had for line 38.
| - **IMPORTANT**: Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0 (see [issue #15](https://github.com/gemini-cli-extensions/flutter/issues/15)) | ||
| - If the user is on Flutter stable ≤ 3.37.0, warn them that hot reload may fail during this debugging session | ||
| - Suggest they either: | ||
| 1. Switch to Flutter main/master channel for full hot reload support, OR |
| - [ ] Run `flutter doctor` to get the Flutter and Dart SDK versions and check for any issues reported. | ||
| - [ ] Check the Flutter version output and determine if hot reload is supported: | ||
| - **IMPORTANT**: Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0 (see [issue #15](https://github.com/gemini-cli-extensions/flutter/issues/15)) |
There was a problem hiding this comment.
Suggested change
| - **IMPORTANT**: Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0 (see [issue #15](https://github.com/gemini-cli-extensions/flutter/issues/15)) | |
| - Hot reload only works reliably on Flutter at versions at or above 3.37.0. If hot_reload fails, and they are using a version below that, inform the user and suggest either switching to the Flutter main channel or manually reloading the app. |
No need to reference the bug.
| - [ ] Check the Flutter version output and determine if hot reload is supported: | ||
| - **IMPORTANT**: Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0 (see [issue #15](https://github.com/gemini-cli-extensions/flutter/issues/15)) | ||
| - If the user is on Flutter stable ≤ 3.37.0, warn them that hot reload may fail during this debugging session | ||
| - Suggest they either: |
There was a problem hiding this comment.
You can remove this entire item if you use the suggestion from line 38 above.
| - Add strategic logging statements to the code to trace execution flow. Prefer `debugPrint()` over `print()` for cleaner, non-interfering output. | ||
| - Use `hot_reload` to apply logging changes quickly while preserving the app's state. If the state needs to be reset, explain that a Hot Restart is needed, and you will need to stop and restart the app. | ||
| - Use `hot_reload` to apply logging changes quickly while preserving the app's state. | ||
| - **Note**: If the user is on Flutter stable ≤ 3.37.0 and hot_reload fails, suggest they manually restart the app or switch to Flutter main channel |
There was a problem hiding this comment.
Suggested change
| - **Note**: If the user is on Flutter stable ≤ 3.37.0 and hot_reload fails, suggest they manually restart the app or switch to Flutter main channel | |
| - Hot reload only works reliably on Flutter at versions at or above 3.37.0. If hot_reload fails, and they are using a version below that, inform the user and suggest either switching to the Flutter main channel or manually reloading the app. |
| - [ ] Use `git diff` to verify the changes that have been made, and create a suitable commit message for any changes, following any guidelines you have about commit messages. Be sure to properly escape dollar signs and backticks, and present the change message to the user for approval. | ||
| - [ ] Wait for approval. Don't commit the changes or move on to the next phase of implementation until the user approves the commit. | ||
| - [ ] After commiting the change, if an app is running, use the hot_reload tool to reload it. | ||
| - **Note**: Hot reload does not work reliably on Flutter stable ≤ 3.37.0. If hot_reload fails, inform the user and suggest either switching to Flutter main channel or manually restarting the app. |
There was a problem hiding this comment.
Suggested change
| - **Note**: Hot reload does not work reliably on Flutter stable ≤ 3.37.0. If hot_reload fails, inform the user and suggest either switching to Flutter main channel or manually restarting the app. | |
| - Hot reload only works reliably on Flutter at versions at or above 3.37.0. If hot_reload fails, and they are using a version below that, inform the user and suggest either switching to the Flutter main channel or manually reloading the app. |
|
Hi @meylis1998 , any thoughts on the review? |
|
Might also address #8 |
|
Hi @gspencergoog! Thanks for the thorough review. Your suggestions make the messaging much clearer and more user-friendly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #15 by adding version detection warnings for hot reload in all commands that use the
hot_reloadtool.Changes
/debug-appcommand: Added early Flutter version check in the "Dependency and Environment Checks" section that warns users if they're on Flutter stable ≤ 3.37.0 and provides clear workarounds/create-appand/modifycommands: Added inline warnings when usinghot_reloadto inform users about the limitationProblem
Hot reload through the Dart MCP server does not work reliably on Flutter stable ≤ 3.37.0. This leaves users confused when hot reload fails without explanation.
Solution
Instead of waiting for the upstream Dart SDK fix, this PR improves the user experience by:
Testing
The warnings are embedded in command prompts and will be displayed by the AI assistant when users run the affected commands on Flutter stable ≤ 3.37.0.
Related Issues
Closes #15
Test Plan
/debug-appon Flutter stable ≤ 3.37.0 and verify version warning appears