Skip to content

Conversation

@Rob9786
Copy link
Collaborator

@Rob9786 Rob9786 commented Sep 1, 2025

Make sure you have checked all steps below.

Issue

  • My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
    Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
    for your progress.

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • No additional tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

@Rob9786 Rob9786 linked an issue Sep 1, 2025 that may be closed by this pull request
@Rob9786 Rob9786 changed the title 5559: Test commit to see if it builds 5559: Remove stopping ECS tasks from the teardown script Sep 1, 2025
@Rob9786
Copy link
Collaborator Author

Rob9786 commented Sep 2, 2025

Span up a test stack and cluster. Started ingesting records. Ran the teardown.sh script. All of the stacks deleted cleanly and the new lambda plus logging worked as expected.

@Rob9786 Rob9786 added the needs-reviewer Pull requests that need a reviewer to be assigned label Sep 2, 2025
@Rob9786 Rob9786 marked this pull request as ready for review September 2, 2025 12:25
Copy link
Collaborator

@patchwork01 patchwork01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like right now this would break the teardown script for all the ECS clusters except for ingest. The new teardown needs applying to the other ECS clusters first, in issue #5566.

@patchwork01 patchwork01 removed the needs-reviewer Pull requests that need a reviewer to be assigned label Sep 3, 2025
@patchwork01 patchwork01 merged commit 93134c5 into develop Oct 14, 2025
3 checks passed
@patchwork01 patchwork01 deleted the 5559-remove-stopping-ecs-tasks-from-the-teardown-script branch October 14, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove stopping ECS tasks from the teardown script

4 participants