Issue 5425 - Add new shut down ECS cluster Lambda into the CDK

[Rob9786]

Make sure you have checked all steps below.

Issue

• My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
  Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
  for your progress.
  • Resolves Add new shut down ECS cluster Lambda into the CDK #5425

Tests

• My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
  • No new tests

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
  separate issue for that below.
• If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
• If I have added or removed any dependencies from the project, I have updated the NOTICES file.

Related tasks

• Remove stopping ECS tasks from the teardown script #5559
• Re-factor CDK Custom Resources so they are deployed in their own stack #5565
• Add AutoStopEcsClusterTasks to other stacks. #5566

[Rob9786]

Although stop tasks code is running when a cluster delete is requested, the cluster is still failing to delete cleanly.
I've attached screenshots showing what is happening:

Autostop was requested at 08:03:12:

The task is stopped on the cluster:

The delete cluster fails with the following error:

This is reported at 09:03:08 (ignore the hour difference), but this is reported before the task actually stopped.
IngestClusterAutoStop event (on CloudTrail) was triggered at 09:03:07.

If you retry deleting the CloudFormation stack it will now delete cleanly, so there is some sort of timing issue where AWS attempts to delete the cluster before the task has fully stopped.

This particular stack and logs is stevecc-0822

[Rob9786]

Attempted another run. I've attached the Cloudwatch Log Insights download. I've observed this before where the task has been stopped but then records have still been output afterwards.
logs-insights-results.xlsx

[Rob9786]

Adding a dependency between the lambda and the stack has corrected the issue. The stack is now deleting cleanly on AWS.

[patchwork01]

Thanks very much.