Skip to content

Version 5.3.0 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2025
Merged

Version 5.3.0 #69

merged 2 commits into from
Aug 11, 2025

Conversation

Rangi42
Copy link
Collaborator

@Rangi42 Rangi42 commented Jul 30, 2025 •
edited
Loading

@Rangi42 Rangi42 force-pushed the next branch 2 times, most recently from 4d0c5c1 to 04d3f9b Compare August 7, 2025 22:45
@Rangi42 Rangi42 marked this pull request as ready for review August 7, 2025 22:48
@Rangi42 Rangi42 requested a review from avivace August 7, 2025 22:48
@Rangi42
Copy link
Collaborator Author

Rangi42 commented Aug 7, 2025 •
edited
Loading

If we're still not ready for a major version update, I can just remove the AUD3WAVERAM change. (Although if we want to fix that issue at all, then at some point there would be a "6.0" which just changes that one constant.)

avivace
avivace previously requested changes Aug 7, 2025
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardware.inc has an history of 5+ years between majors and I honestly don't see the point in pushing for another major this quickly. 5.0 was unjustifiably rushed and with that we skipped a "grace" / "RC" period that would have allowed more changes to be shipped in. We now have to deal with the effects of that.

Please keep "breaking changes" as retro-compatible aliases if you really want to already push them it.

@Rangi42
Version 5.3.0
ec09b27 
* Added `COLOR_CH_WIDTH` and `COLOR_CH_MAX` constants

* Added `JOYP_SGB_*` constants

* Added more `BOOTUP_*` value constants

* Corrected comments on some audio registers
@Rangi42 Rangi42 requested a review from avivace August 8, 2025 04:05
@Rangi42
Copy link
Collaborator Author

Rangi42 commented Aug 8, 2025 •
edited
Loading

No problem, this is now for 5.3.0 without renaming _AUD3WAVERAM to AUD3WAVERAM.

@Rangi42 Rangi42 changed the title Version 6.0.0 Version 5.3.0 Aug 8, 2025
@Rangi42 Rangi42 merged commit 5b87195 into gbdev:master Aug 11, 2025
2 checks passed
@Rangi42 Rangi42 deleted the next branch August 11, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define more SGB constants Define color channel constants
2 participants
@Rangi42 @avivace