Skip to content

Conversation

@Crola1702
Copy link
Contributor

@Crola1702 Crola1702 commented Jul 26, 2024

🦟 Bug fix

Disables failing test from #1887

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Crola1702 Crola1702 requested review from Blast545 and azeey July 26, 2024 16:32
@Crola1702 Crola1702 requested a review from mjcarroll as a code owner July 26, 2024 16:32
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 26, 2024
@Crola1702 Crola1702 self-assigned this Jul 26, 2024
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the original issue as a comment in the code?

LGTM, I think it's reasonable to wait for someone in the dev team to review before merging.

Signed-off-by: Crola1702 <[email protected]>
@Blast545
Copy link
Contributor

Also cc: @scpeters for awareness. We are disabling it for now, but we'll start tracking the tests disabled by the buildfarm team and ping the team/community for help on those every now and then.

Signed-off-by: Crola1702 <[email protected]>
@Crola1702 Crola1702 merged commit 9891844 into ign-gazebo6 Jul 26, 2024
@Crola1702 Crola1702 deleted the Crola1702/disable-failing-test branch July 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants