fix(gatsby): copy slices overrides to 404.html copy #38337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
…omparison to decide wether to update a copy
pieh
commented
Jul 3, 2023
|
|
||
| originalStatusPageByStatus[status] = storedPage | ||
| originalStatusPageByPath[action.payload.path] = storedPage | ||
| if (!originalPage || !isEqual(originalPage, pageToStore)) { |
Contributor
Author
There was a problem hiding this comment.
isEqual check here was added (on top of using action.payload.slices) so that cases like src/pages/404.js + onCreatePage hook that adds slices (or context) can work as otherwise original page would be used and we would ignore potential future edits to the page.
LekoArts
approved these changes
Jul 3, 2023
LekoArts
added
the
topic: core
LekoArts
changed the title
This was referenced Sep 23, 2023
This was referenced Sep 29, 2023
This was referenced Oct 7, 2023
This was referenced Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating copy of 404 / 500 pages (from
/404/to/404.html), slices overrides where not copied over. This casued slice aliasing not work in those pages.Tests
Yes, e2e cases added to dev and prod runtimes
Related Issues
Fixes #38263