Skip to content

fix(gatsby): make sure 404 and 500 pages inherit stateful status from original page #33544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021
+3 −3
Merged

fix(gatsby): make sure 404 and 500 pages inherit stateful status from original page #33544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/gatsby/src/internal-plugins/prod-404-500/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ emitter.on(`CREATE_PAGE`, action => {
...storedPage,
path: `/${status}.html`,
},
action.plugin
action.plugin,
action
Comment on lines +35 to +36
Copy link
Contributor Author

@pieh pieh Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pass third arg (actionOptions) so that this check

gatsby/packages/gatsby/src/redux/actions/public.js

Lines 397 to 398 in 83396a5

isCreatedByStatefulCreatePages:
actionOptions?.traceId === `initial-createPagesStatefully`,
actually do something.

actionOptions are spread on CREATE_PAGE action itself -

gatsby/packages/gatsby/src/redux/actions/public.js

Lines 492 to 498 in 83396a5

{
...actionOptions,
type: `CREATE_PAGE`,
contextModified,
plugin,
payload: internalPage,
},

)
)
}
Expand Down
3 changes: 1 addition & 2 deletions packages/gatsby/src/utils/changed-pages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ export function deleteUntouchedPages(
if (
(shouldRunCreatePagesStatefully ||
!page.isCreatedByStatefulCreatePages) &&
page.updatedAt < timeBeforeApisRan &&
page.path !== `/404.html`
page.updatedAt < timeBeforeApisRan
) {
store.dispatch(deletePage(page))
deletedPages.push(page.path, `/page-data${page.path}`)
Expand Down