fix(gatsby): fix hydration flicker on initial render of ssr page #33134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
commented
Sep 10, 2021
pieh
force-pushed
the
fix/ssr/flicker
branch
from
a128345 to
bdf42b5
Compare
pieh
added
topic: render-mode
sidharthachatterjee
previously approved these changes
Sep 13, 2021
Contributor
sidharthachatterjee
left a comment
sidharthachatterjee
left a comment
There was a problem hiding this comment.
Nice! I was about to push a fix for this. Thank you for doing this!
pieh
commented
Sep 13, 2021
Comment on lines
-103
to
-111
| let hasPageData = false | ||
| if (pages.size) { | ||
| // test if 1 page-data file exists, if it does we know we're on a gatsby version that supports page-data | ||
| const pageDataPath = publicFolder( | ||
| getPageDataPath(pages.get(pages.keys().next().value).path) | ||
| ) | ||
| hasPageData = existsSync(pageDataPath) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This heuristic is no longer working as intended with non-ssg pages and it was there to support really old gatsby version (early v2?)
This was referenced Sep 15, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…sbyjs#33134) * inline page-data object in html when it contains serverData * skip settting page-data preload link header for ssr pages
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes essentially running
getServerDatatwice for same page (once for html and once for page-data) by inlining page-data in html response and hydrating pageData cache so that we never even need page-data requestNote
This will require also Link headers to be not be there for
page-datafile whengetServerDatais used