Skip to content

Conversation

@LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 6, 2021

Description

The flags were missing from the GatsbyConfig interface.

Side note: In a later iteration we could think of creating string literals instead of string so that people would get type hints for all experiments based of our current flags (so dynamically created)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 6, 2021
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 6, 2021
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks for the fix

@LekoArts LekoArts merged commit 5f711fc into master Jan 7, 2021
@LekoArts LekoArts deleted the flags-ts-types branch January 7, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants