Fix(gatsby-plugin-image): Render LayoutWrapper prior to loading of lazy-hydrate #28841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: media
gatsbybot
pushed a commit
that referenced
this pull request
Jan 13, 2021
…zy-hydrate (#28841) (#28990) * add layoutwrapper to intial render when lazy-hydrate hasn't yet run * calculate sizer string (cherry picked from commit 78e5e47) Co-authored-by: LB <[email protected]>
Contributor
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, fluid and constrained images trigger a re-layout because the sizer div (living in LayoutWrapper) hasn't loaded yet. This is not a challenge for SSR, but for route navigation.
This updates the dangerouslySetInnerHTML hack to use the sizer elements that fluid and constrained need.
[ch21582]