Skip to content

feature(gatsby): let users skip out of dev SSR #28396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 1, 2020
Merged

feature(gatsby): let users skip out of dev SSR #28396

merged 6 commits into from
Dec 1, 2020

Conversation

@KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Dec 1, 2020 •
edited
Loading

h/t to @pieh for idea

Screen Shot 2020-11-30 at 6 01 49 PM

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 1, 2020
@KyleAMathews KyleAMathews added type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 1, 2020
@pieh pieh self-assigned this Dec 1, 2020
pieh
pieh approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you!

@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 1, 2020
@gatsbybot gatsbybot merged commit 7577e3f into master Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the skip-ssr branch December 1, 2020 14:57
@gatsbybot gatsbybot mentioned this pull request Dec 1, 2020
Merged
pieh added a commit that referenced this pull request Dec 1, 2020
@KyleAMathews @pieh
feature(gatsby): let users skip out of dev SSR (#28396)
169986e 
* feature(gatsby): let users skip out of dev SSR

* update snapshot

* update snapshot

* Add link on ssr error page to the docs

* copy fix

* update snapshot

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 7577e3f)
pieh pushed a commit that referenced this pull request Dec 1, 2020
@KyleAMathews
feature(gatsby): let users skip out of dev SSR (#28396) (#28423)
7df196c 
* feature(gatsby): let users skip out of dev SSR

* update snapshot

* update snapshot

* Add link on ssr error page to the docs

* copy fix

* update snapshot

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 7577e3f)

Co-authored-by: Kyle Mathews <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels

bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KyleAMathews @pieh @gatsbybot