Skip to content

Conversation

@wardpeet
Copy link
Contributor

Description

When page-data.json results in a 500 or when we can't fetch a component we've hit some js errors instead of our own. So now we are actually throwing gatsby errors and error trackers make more sense.

Before:

  • When component can't be loaded we had: TypeError: e.components[t] is not a function and loaded the 404 page.
  • when page-data results in 500 we had: TypeError: Cannot read property 'webpackCompilationHash' of undefined and refresh the page.

After:

  • When component can't be loaded we have: Error: page resources for /stale/ not found. Not rendering React and loaded the 404 page.
  • when page-data results in 500 we have: Error: page resources for /new-beginnings/ not found. Not rendering React' of undefined and refresh the page.

Related Issues

#21429

@wardpeet wardpeet requested a review from a team February 28, 2020 15:13
@freiksenet freiksenet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 2, 2020
@gatsbybot gatsbybot merged commit a87f1bd into gatsbyjs:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: merge on green Gatsbot will merge these PRs automatically when all tests passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants