Skip to content

feat(create-remote-file-node): add url field to downloaded file nodes #12582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2019
Merged

feat(create-remote-file-node): add url field to downloaded file nodes #12582

merged 3 commits into from
Mar 14, 2019

Conversation

@DarioDiem
Copy link
Contributor

@DarioDiem DarioDiem commented Mar 14, 2019

Description

Related Issues

@pieh pieh changed the title Topics/create remote file node image url feat(create-remote-file-node): add url field to downloaded file nodes Mar 14, 2019
pieh
pieh approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarioDiem!

@pieh pieh merged commit cac37a9 into gatsbyjs:master Mar 14, 2019
@gatsbot
Copy link

gatsbot bot commented Mar 14, 2019

Holy buckets, @DarioDiem — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Mar 14, 2019

[email protected] was published with this change

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@DarioDiem @pieh
feat(create-remote-file-node): add url field to downloaded file nod…
643153a 
…es (gatsbyjs#12582)

<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

<!-- Write a brief description of the changes introduced by this PR -->

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieh pieh pieh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarioDiem @pieh