fix(gatsby): Only use one redux namespace for plugins #12263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
this is cool! Thanks for the cleanup, I still need to test this out. Removing these namespaces does this mean it's a breaking change? I haven't looked really at it. |
Contributor
Author
|
I don't think this was public API (?), so should be good. |
Contributor
Author
|
Looks like the one usage in |
Contributor
Author
|
@wardpeet Have you had a chance to look at this? Thanks! |
Contributor
Author
|
Anything missing from this? |
Contributor
|
doing it tomorrow! |
DSchau
added
the
status: awaiting reviewer response
Contributor
|
Tomorrow took a while but i've tested it and read through the code and it looks 👌 Thanks! |
wardpeet
approved these changes
Apr 2, 2019
Contributor
Author
|
Cool thanks! |
Contributor
|
Published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have three redux namespaces for plugins (
flattenedPlugins,plugins,apiToPlugins). This PR reduces this to justflattenedPlugins.Also: use
flattenedPlugins.nodeAPIsinapi-runner-nodeandpage-hot-reloader.