Pass auth to Active RM check #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimon222
force-pushed
the
bugfix/fix_active_kerberos_check
branch
from
82022a1 to
6010ea0
Compare
dimon222
force-pushed
the
bugfix/fix_active_kerberos_check
branch
from
6010ea0 to
af57fef
Compare
kevin-bates
reviewed
Oct 9, 2019
|
@kevin-bates i've applied the suggested change. Logger is not accessible from method, so it's printing to stdout for time being. |
|
I've validated new active RM check on existing cluster with such setup and it seems to work. One suggestion is still have in mind - response.text is showing very verbose output of page markup (basically html). Maybe it makes more sense to keep only the status code in log instead of full response body? |
|
Yes - that sounds good. Thank you for checking this! |
|
Adjusted the print statement. Hopefully nothing else missed. |
|
@lresende any chance u can confirm as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #57
One thing I'm still not sure about is next:
https://github.com/dimon222/hadoop-yarn-api-python-client/blob/82022a1574c6134ade132736ef64d642053b13dc/yarn_api_client/hadoop_conf.py#L52-L57
Should we validate for 401 and throw exception for auth immediately or its valid scenario when we should return just False?